Repository navigation
fix(http): reject HTTP/1 responses with non-chunked final Transfer-Encoding - #1109
Open
deepak-pandey2005 wants to merge 1 commit into
Open
deepak-pandey2005 wants to merge 1 commit into
deepak-pandey2005 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1042
Summary
Transfer-Encodingis present butchunkedis not the final transfer coding, in accordance with RFC 9112 §6.3.test_response_multiple_te_headers_chunked_not_lastand addtest_response_single_te_header_not_chunkedregression tests.Motivation
Per RFC 9112 §6.3:
While the server side (
HttpSession::validate_request) already enforces!self.is_chunked_encoding(),HttpSession::validate_responseinprotocols/http/v1/client.rslacked this check, leading to inconsistent framing handling and potential request/response desynchronization risks.Design
HttpSession::validate_response: ifresp_header.headers.contains_key(header::TRANSFER_ENCODING)and!self.is_chunked_encoding(), immediately returnError::e_explain(InvalidHTTPHeader, "non-chunked final Transfer-Encoding").Tests
test_response_multiple_te_headers_chunked_not_lastto assertInvalidHTTPHeadererror.test_response_single_te_header_not_chunkedto verify single non-chunked TE headers.pingora-coreHTTP/1 client unit tests pass.